Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added TypedEnv, for easy parsing of env-vars #451

Merged
merged 1 commit into from
Jul 4, 2019
Merged

added TypedEnv, for easy parsing of env-vars #451

merged 1 commit into from
Jul 4, 2019

Conversation

koreno
Copy link
Collaborator

@koreno koreno commented Jun 26, 2019

No description provided.

@koreno koreno requested a review from henryiii June 26, 2019 21:05
@coveralls
Copy link

coveralls commented Jun 26, 2019

Coverage Status

Coverage increased (+0.05%) to 82.408% when pulling 73ca017 on typed-env into d2b7b16 on master.

@henryiii
Copy link
Collaborator

Python 2 support, please. We haven't dropped Python 2.6 yet, though that's planned for 1.7. A future 2.0 could drop Python 2 support. Since Plumbum is a scripting helper, it should work with any system Python, and CentOS 7 still is on 2.6, macOS is on 2.7 (until it drops all scripting languages in a release or two, anyway).

@henryiii
Copy link
Collaborator

I think you could just move the ** test into a test marked with Python3 only.

@henryiii
Copy link
Collaborator

Would you be interested in writing docs/changelog for this and the other additions you've just made? If not I will, but it would be slightly delayed, probably.

@koreno
Copy link
Collaborator Author

koreno commented Jul 4, 2019

@henryiii - should I merge this?

@henryiii henryiii merged commit 0b0efd3 into master Jul 4, 2019
@henryiii
Copy link
Collaborator

henryiii commented Jul 4, 2019

It’s okay, I can. Have been busy so ping me as needed (like you did).

AndydeCleyre added a commit to AndydeCleyre/plumbum that referenced this pull request Jan 4, 2020
It was pointing to tomerfiliba#450, making it very hard to learn about TypedEnv.
AndydeCleyre added a commit to AndydeCleyre/plumbum that referenced this pull request Jan 6, 2020
henryiii pushed a commit that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants