Fix incorrect __getitem__ method in Path #506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumbum doesn't support PathLike logics, because Path class is inherited from str and therefore considered as str in python libraries (
__fspath__
method is never called). Before #455 everything was fine, but after the corresponding commit libraries are unable to use plumbum Path as string, because__getitem__
returns strange thinks for int and slice keys.Consider the following example:
Before #455 the output is as expected:
But after the commit it is meaningless:
I fix this bug by returning the old
__getitem__
behaviour forint
andslice
keys.