make iter_lines deal with decoding errors during iteration; Also... #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It fails on that same pypy cryptography issue, unrelated to the code changes |
|
Restarting the CI by closing and opening the PR should restart the "PR" job based on PR'ing to current master and this time it should pass. |
|
But travis is p.a.i.n.f.u.l.l.l.l.l.y slow as it dies. |
henryiii
reviewed
Dec 25, 2020
remove broken support for no-decoding
henryiii
force-pushed
the
encoding-resilient-iter-lines
branch
from
6c143a1 to
b332202
Compare
|
Sorry for the delay, needed lots of CI work, we now have a unified GHA suite and completes in a few minutes and has better coverage. :) |
henryiii
force-pushed
the
encoding-resilient-iter-lines
branch
from
c9893f2 to
bcae309
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove broken support for no-decoding