Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenSSH forwarding Unix sockets #550

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

lbenezriravin
Copy link
Contributor

I tried to make the interface as sane as possible while maintaining as a small diff and backwards compatibility. Let me know if you'd like it to look different. Thanks for working on this project!

OpenSSH clients can forward Unix sockets instead of TCP ports with the
same -L flag using a slightly modified argument. This patch should
allow users to take advantage of the full syntax. From the man pages:

     -L [bind_address:]port:host:hostport
     -L [bind_address:]port:remote_socket
     -L local_socket:host:hostport
     -L local_socket:remote_socket

This patch also adds a protection for the feature.

@coveralls
Copy link

coveralls commented Jul 10, 2021

Coverage Status

Coverage decreased (-0.01%) to 82.298% when pulling b3ed502 on StarryInternet:lihu/af_unix into e6412b2 on tomerfiliba:master.

@lbenezriravin
Copy link
Contributor Author

@henryiii Is this a feature you're open to?

@henryiii
Copy link
Collaborator

Yes, I just hadn't reviewed it yet. Could you add an entry to the changelog?

OpenSSH clients can forward Unix sockets instead of TCP ports with the
same `-L` flag using a slightly modified argument. This patch should
allow users to take advantage of the full syntax. From the man pages:

```
     -L [bind_address:]port:host:hostport
     -L [bind_address:]port:remote_socket
     -L local_socket:host:hostport
     -L local_socket:remote_socket
```

This patch also adds a protection for the feature.
@lbenezriravin
Copy link
Contributor Author

Sure thing. Thanks for taking a look.

@henryiii henryiii merged commit bcf7078 into tomerfiliba:master Jul 23, 2021
@henryiii
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants