Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new Application property: COLOR_GROUP_TITLES #553

Merged
merged 3 commits into from
Jul 23, 2021

Conversation

ink-splatters
Copy link
Contributor

Hello,

Thanks a lot for the great framework!

I'm migrating a CLI app from click to plumbum and it's going like a charm!

But got an idea for a small feature/improvement;

hence the pull request:

  • COLOR_GROUP_TITLES property introduced and documented
  • test_clicolor.py modified to cover the new case

Cheers,
Peter

* introducing COLOR_GROUP_TITLES Application property to specify the
  color of group title
* fallback to COLOR_GROUPS color if COLOR_GROUP_TITLES is None
* modifying test_clicolor.py to cover the new functionality
* modifying related files
* fixing lint error (black)
* documentation modified
* test_clicolor.py extended
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 82.305% when pulling c38c1a0 on ink-splatters:master into e6412b2 on tomerfiliba:master.

@henryiii henryiii merged commit c95b8ee into tomerfiliba:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants