fix(server): 🐛 add bundled flag to rusqlite dependency on musl-libc #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arget - fix tonarino#228 - the musl libc is used on Alpine, a minimal linux distribution commonly used in docker images. It's also used on OpenWRT which might be of interest to innernet.
strohel
reviewed
Aug 8, 2022
Comment on lines
+50
to
+51
| [target.'cfg(target_env = "musl")'.dependencies] | ||
| rusqlite = { version = "0.28", features = ["bundled"] } |
There was a problem hiding this comment.
Can you please add a brief comment here with explanation? Perhaps mentioning the issue number.
|
Seems reasonable to me, especially since it only affects the musl target. |
|
I'll merge this, and then add a little comment linking to the rusqlite issue. Thanks! EDIT: It's been a minute, mis-remembered about sqlite not being a dep on the client :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(server): 🐛 add bundled flag to rusqlite dependency on musl-libc target
innernet-server newwizard on Alpine Linux #228used in docker images. It's also used on OpenWRT which might be of
interest to innernet.