add some config #4310
Merged
add some config #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPWstatic
reviewed
Jun 9, 2022
conf/nebula-graphd.conf.default
Outdated
| # Network IO threads number, 0 means physical cpu core num | ||
| --num_netio_threads=0 | ||
| # Worker threads number to handle request, 0 means physical cpu core num | ||
| --num_worker_threads=0 |
There was a problem hiding this comment.
We have these two config on line 62-65
wenhaocs
reviewed
Jun 9, 2022
conf/nebula-storaged.conf.default
Outdated
| --num_io_threads=16 | ||
| # Worker threads number to handle request | ||
| --num_worker_threads=32 | ||
| # Maximum subtasks to run concurrently |
There was a problem hiding this comment.
be more precise "... for admin jobs"
|
Will we change it in Open Source edition, or just in Enterprise edition? cc @xiajingchun |
HarrisChu
approved these changes
Jun 14, 2022
wenhaocs
approved these changes
Jun 14, 2022
Sophie-Xie
added
cherry-pick-v3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close #4246
Description:
Add some configs into configuration files which are commonly used.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Note sure if all these newly added configs are in doc.
Release notes:
Please confirm whether to be reflected in release notes and how to describe: