fix the bug when alter column that doesn't have a default value to no… #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
force-pushed
the
fix-alter-not-null
branch
from
99cc4b5 to
5d3a2b4
Compare
yixinglu
reviewed
Dec 23, 2022
jievince
force-pushed
the
fix-alter-not-null
branch
from
5d3a2b4 to
d4ef191
Compare
critical27
reviewed
Dec 26, 2022
| @@ -59,6 +60,12 @@ static Status validateColumns(const std::vector<ColumnSpecification *> &columnSp | |||
| if (!column.nullable_ref().has_value()) { | |||
| column.nullable_ref() = true; | |||
There was a problem hiding this comment.
I found this problem recently as well, do you know why? This is quite implicit...
There was a problem hiding this comment.
I found this problem recently as well, do you know why? This is quite implicit...
Is there any related issue? I don't know which problem you're talking about.
xtcyclist
previously approved these changes
Dec 26, 2022
xtcyclist
force-pushed
the
fix-alter-not-null
branch
from
2bb0494 to
5e2385c
Compare
xtcyclist
approved these changes
Dec 26, 2022
critical27
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t nullable
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fix https://github.com/vesoft-inc/nebula-ent/issues/1973
Fix #4809
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: