RSDK-10084 - Add documentation warning for embedded structs in NativeConfig #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
benjirewis
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Thanks!
To be clear, it's not really NativeConfig that's the issue, right? NativeConfig is just doing a type cast. It's really the default AttributeMapConverter that gets borked with embedded structs? And, we're calling NativeConfig on that borked thing?
With that said, from a module developer perspective, I guess they'll run into what @njooma ran into with NativeConfig, so this is where they'll encounter the issue. So placement seems fine, but comment might be slightly misleading.
viambot
added
safe to test
|
updated the docstring, happy to hear any suggestions on wording if this is still a bit misleading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.