Pyification #148
Merged
Pyification #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jens-erdmann
force-pushed
the
pyification
branch
2 times, most recently
from
8e0433f to
29430f6
Compare
|
|
jens-erdmann
force-pushed
the
pyification
branch
6 times, most recently
from
a472ebe to
4e7a047
Compare
I removed that one for now until I understand the errors in test. Seems like I am breaking stuff by oversimplifying. 😅 |
jens-erdmann
force-pushed
the
pyification
branch
2 times, most recently
from
343c6fd to
9bcd85e
Compare
|
depends on #151 |
Instead of crafting a string from a list manually the python builtin join was used. Signed-off-by: Jens Erdmann <[email protected]>
Rework license_expression_set_list_to_string function by making more use of built in python functions instead of implementing joins by hand. Signed-off-by: Jens Erdmann <[email protected]>
Rework function interim_license_expression_list_to_string to be more python instead of c style. Removing logic to determine first items and inserting delimiters. Signed-off-by: Jens Erdmann <[email protected]>
Replace logic to hand craft string in c style with actual python builtin formatted string. Signed-off-by: Jens Erdmann <[email protected]>
Replace c style string concatination with python formatted string. Signed-off-by: Jens Erdmann <[email protected]>
jens-erdmann
force-pushed
the
pyification
branch
from
9bcd85e to
2085a6c
Compare
priv-kweihmann
approved these changes
Nov 16, 2021
The markdown stuff is covered as I learned by failing a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert c style joins to python joins.
Simplify display_compatibility function.
See commits for details.