Refactor: More Inlining of Object Creation #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of adding diffrent attributes of an object one by one this change is lining the procedure by creating an object all at once. This should be less consuming due to less lookups inside of the object. Signed-off-by: Jens Erdmann <[email protected]>
Instead of adding diffrent attributes of an object one by one this change is lining the procedure by creating an object all at once. This should be less consuming due to less lookups inside of the object. Signed-off-by: Jens Erdmann <[email protected]>
Convert method supported_licenses to list comprehension to be more pythonic. Signed-off-by: Jens Erdmann <[email protected]>
priv-kweihmann
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework more findings into more pythonic code.
See commits for details.