Report: Refactor Class #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some intermediate assignments by just returning early. Functionality should be unchanged. Signed-off-by: Jens Erdmann <[email protected]>
Refactor report class by removing report_map and all its invocations. report_map lead to confusion about what the actual report is. Make most methods private that were only used for initialization. Make outbound_candidates a method. The anonymous function made not much sense on its own. Replace all access to the inner dict for outbound_candidates with the new method to hide internal details. Rework to_json method to enable the refactored class to be serialized. Signed-off-by: Jens Erdmann <[email protected]>
priv-kweihmann
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor report class by removing report_map and all its invocations.
report_map lead to confusion about what the actual report is.
Make most methods private that were only used for initialization.
Make outbound_candidates a method. The anonymous function made not much
sense on its own. Replace all access to the inner dict for
outbound_candidates with the new method to hide internal details.
Rework to_json method to enable the refactored class to be serialized.