Flake8: Update Ignore for Prints #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pipelines currently fail with the following error: |
|
Then please also ensure that we are installing flake8-print > 5.0 in the requirements-dev.txt |
Update flake8 ignore list. With version 5.0 of flake8-print the namespace got moved from T0* to T2*. To keep ignoring prints this has to be reflected in the ignore list. Hence the T001 > T201. Also make flake8-print 5.0.0 the minimum requirement. Signed-off-by: Jens Erdmann <[email protected]>
Good point. Modified the changes accordingly. |
priv-kweihmann
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flake8 ignore list. With version 5.0 of flake8-print the namespace got moved from T0* to T2*. To keep ignoring prints this has to be reflected in the ignore list. Hence the T001 > T201.
Also make flake8-print 5.0.0 the minimum requirement.
Signed-off-by: Jens Erdmann [email protected]