flict-config: safety fallback for HOME #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if HOME is not set (and there might be even obscure Unix setups that do that), the app crashes at startup. Fix that by providing a non-existing dir. For users that need to have flict-config without HOME dir being present still FLICT_USERCONFIG is available. That one can be used to provide a full qualified path of a cfg file to be used Relates to vinland-technology#251 Signed-off-by: Konrad Weihmann <[email protected]>
|
Is this a temporary solution or supposed to last longer? I remember a discussion about using a different library to handle paths platform independent. |
For me that is the solution we should stick to as long as we only support POSIX Linux - if Windows support becomes reality we might want to switch to something different, but I do not see that coming, I would be fine with just preventing a crash |
jens-erdmann
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if HOME is not set (and there might be even obscure Unix setups that do that), the app crashes at startup.
Fix that by providing a non-existing dir.
For users that need to have flict-config without HOME dir being present still FLICT_USERCONFIG is available. That one can be used to provide a full qualified path of a cfg file to be used
Relates to #251
Signed-off-by: Konrad Weihmann [email protected]