fix: fix minify when builder.sharedPlugins: true

packages/vite/src/node/__tests__/build.spec.ts

@@ -733,6 +733,69 @@ test('default sharedConfigBuild true on build api', async () => {
   expect(counter).toBe(1)
 })
 
+test('minify per environment when builder.sharedPlugins', async () => {
+  const root = resolve(__dirname, 'fixtures/shared-plugins/minify')
+  const builder = await createBuilder({
+    root,
+    logLevel: 'warn',
+    environments: {
+      client: {
+        build: {
+          outDir: './dist/client',
+          rollupOptions: {
+            input: '/entry.js',
+          },
+        },
+      },
+      ssr: {
+        build: {
+          outDir: './dist/server',
+          rollupOptions: {
+            input: '/entry.js',
+          },
+        },
+      },
+      custom1: {
+        build: {
+          minify: true,
+          outDir: './dist/custom1',
+          rollupOptions: {
+            input: '/entry.js',
+          },
+        },
+      },
+      custom2: {
+        build: {
+          minify: false,
+          outDir: './dist/custom2',
+          rollupOptions: {
+            input: '/entry.js',
+          },
+        },
+      },
+    },
+    builder: {
+      sharedPlugins: true,
+    },
+  })
+  const client = await builder.build(builder.environments.client)
+  const ssr = await builder.build(builder.environments.ssr)
+  const custom1 = await builder.build(builder.environments.custom1)
+  const custom2 = await builder.build(builder.environments.custom2)
+  expect(
+    ([client, ssr, custom1, custom2] as RollupOutput[]).map(
+      (o) => o.output[0].code.split('\n').length,
+    ),
+  ).toMatchInlineSnapshot(`
+    [
+      2,
+      5,
+      2,
+      5,
+    ]
+  `)
+})
+
 test('adjust worker build error for worker.format', async () => {
   try {
     await build({

packages/vite/src/node/__tests__/fixtures/shared-plugins/minify/entry.js

@@ -0,0 +1,4 @@
+function main() {
+  console.log('test')
+}
+main()

packages/vite/src/node/build.ts

@@ -482,7 +482,7 @@ export async function resolveBuildPlugins(config: ResolvedConfig): Promise<{
     ],
     post: [
       buildImportAnalysisPlugin(config),
-      ...(config.esbuild !== false ? [buildEsbuildPlugin(config)] : []),
+      buildEsbuildPlugin(),
       terserPlugin(config),
       ...(!config.isWorker
         ? [manifestPlugin(), ssrManifestPlugin(), buildReporterPlugin(config)]

packages/vite/src/node/plugins/esbuild.ts

@@ -317,7 +317,7 @@ const rollupToEsbuildFormatMap: Record<
   iife: undefined,
 }
 
-export const buildEsbuildPlugin = (config: ResolvedConfig): Plugin => {
+export const buildEsbuildPlugin = (): Plugin => {
   return {
     name: 'vite:esbuild-transpile',
     async renderChunk(code, chunk, opts) {
@@ -326,6 +326,10 @@ export const buildEsbuildPlugin = (config: ResolvedConfig): Plugin => {
         return null
       }
 
+      const config = this.environment.config
+      if (config.esbuild === false) {
+        return
+      }
       const options = resolveEsbuildTranspileOptions(config, opts.format)
 
       if (!options) {