fix(runner): fix and simplify Task.suite initialization
#7414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
commented
Mar 3, 2025
Comment on lines
5
to
23
| test("test-a", (ctx) => { | ||
| expect(ctx.__suiteNames).toEqual([]); | ||
| }) | ||
|
|
||
| describe("suite-x", () => { | ||
| test("test-b", (ctx) => { | ||
| expect(ctx.__suiteNames).toEqual( | ||
| ['suite-x'] | ||
| ) | ||
| }) | ||
|
|
||
| describe("suite-y", () => { | ||
| test("test-c", (ctx) => { | ||
| expect(ctx.__suiteNames).toEqual( | ||
| ['suite-y', 'suite-x'] | ||
| ) | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
On #7374, some tests fail (and pass) in an odd way:
DEV v3.0.7 /home/hiroshi/code/others/vitest/test/cli/fixtures/custom-runner
❯ custom-runner.test.ts (3 tests | 2 failed) 6ms
× test-a 5ms
→ expected [ '' ] to deeply equal []
✓ suite-x > test-b
× suite-x > suite-y > test-c 1ms
→ expected [ 'suite-y' ] to deeply equal [ 'suite-y', 'suite-x' ]
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
FAIL custom-runner.test.ts > test-a
AssertionError: expected [ '' ] to deeply equal []
- Expected
+ Received
- []
+ [
+ "",
+ ]
❯ custom-runner.test.ts:6:27
4|
5| test("test-a", (ctx) => {
6| expect(ctx.__suiteNames).toEqual([]);
| ^
7| })
8|
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯
FAIL custom-runner.test.ts > suite-x > suite-y > test-c
AssertionError: expected [ 'suite-y' ] to deeply equal [ 'suite-y', 'suite-x' ]
- Expected
+ Received
[
"suite-y",
- "suite-x",
]
❯ custom-runner.test.ts:18:29
16| describe("suite-y", () => {
17| test("test-c", (ctx) => {
18| expect(ctx.__suiteNames).toEqual(
| ^
19| ['suite-y', 'suite-x']
20| )
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯
Test Files 1 failed (1)
Tests 2 failed | 1 passed (3)
Start at 14:56:29
Duration 147ms (transform 25ms, setup 0ms, collect 8ms, tests 6ms, environment 0ms, prepare 53ms)
@vitest/browser
@vitest/coverage-istanbul
@vitest/coverage-v8
@vitest/expect
@vitest/mocker
@vitest/pretty-format
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vite-node
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
sheremet-va
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.