Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove vestigial spy stub, import directly from @vitest/spy #7575

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

mrginglymus
Copy link
Contributor

Description

The integration/spy.ts file has been vestigial since #2575. It seems to be confusing rollup-dts-plugin. Rather than bang our heads against a wall fixing that, remove it and just import/export from @vitest/spy directly where referenced.

This appears to fix the output .d.ts files.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e54e213
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67c048237d40bc0008b51ca3
😎 Deploy Preview https://deploy-preview-7575--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mrginglymus
Copy link
Contributor Author

Ahh...not as vestigial as I'd hoped!

Instead, import directly from @vitest/spy
@sheremet-va sheremet-va merged commit 7f7ff11 into vitest-dev:main Feb 27, 2025
13 checks passed
@mrginglymus mrginglymus deleted the rm-spy-stub branch February 27, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built .d.ts files contain js code
2 participants