Update pre-commit prettier version #694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
reviewed
May 11, 2023
| @@ -32,7 +32,7 @@ repos: | |||
| - flake8-bugbear | |||
| - flake8-comprehensions | |||
| - repo: https://github.com/pre-commit/mirrors-prettier | |||
| rev: 'v1.18.2' | |||
| rev: 'v2.7.1' | |||
There was a problem hiding this comment.
@PeteCoward any chance you could drop the linting dependencies from package.json while at this? This way we keep it just in pre-commit.
https://github.com/wagtail/cookiecutter-wagtail-package/pull/47/files has an example.
If not, will make that a follow-up task
There was a problem hiding this comment.
I had a go.
I snuck in a change from pip install -e .[testing] -U to pip install -e '.[testing]' -U too, which caught me out following the README.
I did not make the change to the pre-commit run all files README comment, as I was not sure of the rationale behind it.
|
Thank you for this, @PeteCoward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #693
Upgrading the prettier check to it's latest version v2.7.1 removed these warnings.
The changes in 53d9d8e are the result of the prettier upgrade and consist of
.github/workflows/test.ymlmentioned in the issuefunction (...)Also delegates prettier check to pre-commit as per example https://github.com/wagtail/cookiecutter-wagtail-package/pull/47/files