Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set forkUrl as Output Value #230

Merged
merged 9 commits into from
Oct 12, 2022
Merged

Set forkUrl as Output Value #230

merged 9 commits into from
Oct 12, 2022

Conversation

lelia
Copy link
Collaborator

@lelia lelia commented Oct 4, 2022 •
edited
Loading

Description

Creates a new GitHub Action output which allows the value of the forkUrl string to be accessed by subsequent steps in a GitHub Workflow.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@lelia lelia changed the title Set fork url output Set forkUrl as output value Oct 10, 2022
@lelia lelia changed the title Set forkUrl as output value Set forkUrl as Output Value Oct 10, 2022
@lelia lelia marked this pull request as ready for review October 10, 2022 19:58
@lelia lelia requested review from draco2003 and GaryPWhite October 12, 2022 17:16
draco2003
draco2003 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@draco2003 draco2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Question around Booleans but non-blocking.

@lelia lelia changed the base branch from main to releases/v0.0.6 October 12, 2022 18:07
@lelia lelia merged commit f23a86b into wayfair-incubator:releases/v0.0.6 Oct 12, 2022
@lelia lelia mentioned this pull request Oct 12, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draco2003 draco2003 draco2003 approved these changes

@GaryPWhite GaryPWhite Awaiting requested review from GaryPWhite

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lelia @draco2003