webuipoc: Add Eslint #5507
Merged
webuipoc: Add Eslint #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thc202
reviewed
Jun 14, 2024
thc202
reviewed
Jun 14, 2024
MZ-AD
force-pushed
the
Duplicate-dep-remove
branch
from
10f84ab to
f8168c0
Compare
Signed-off-by: Moeez Ahmed <[email protected]>
MZ-AD
force-pushed
the
Duplicate-dep-remove
branch
from
f8168c0 to
d1d8d85
Compare
thc202
reviewed
Jun 14, 2024
|
This needs to be added back: #5460 (comment) |
Signed-off-by: Moeez Ahmed <[email protected]>
MZ-AD
force-pushed
the
Duplicate-dep-remove
branch
from
e248e6e to
98f9089
Compare
Signed-off-by: Moeez Ahmed <[email protected]>
added |
thc202
reviewed
Jun 14, 2024
There was a problem hiding this comment.
- Missing the lint script entry.
- Is
eslintConfigstill needed? (maybe it is)
There was a problem hiding this comment.
I have just ran the default eslint setup script that is included with eslint package. No manual config is done.
There was a problem hiding this comment.
The eslintConfig was already in the file (even before eslint was being added).
There was a problem hiding this comment.
The first point still needs to be addressed in any case.
thc202
reviewed
Jun 14, 2024
MZ-AD
force-pushed
the
Duplicate-dep-remove
branch
from
b105a61 to
b43ff4a
Compare
Signed-off-by: Moeez Ahmed <[email protected]>
|
The branch has conflicts. |
Signed-off-by: Moeez Ahmed <[email protected]>
thc202
approved these changes
Jun 14, 2024
|
Thank you! |
kingthorin
approved these changes
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.