Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar initialize & dropdown smooth #258

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

mocfaisal
Copy link
Contributor

Make sidebar method as a global function, fix auto calculate height for submenus

Implement for some case if build SPA application, that sidebar can't reinitialize

how to use

const sidebar = new window.Sidebar(document.getElementById("sidebar"), {
                recalculateHeight: true
            })

Patch for issue #257 (comment)

Implement for some case if build SPA application, that sidebar can't reinitialize
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for comforting-cocada-22086c ready!

Name Link
🔨 Latest commit 716e48d
🔍 Latest deploy log https://app.netlify.com/sites/comforting-cocada-22086c/deploys/65168d524a1d4b000751470a
😎 Deploy Preview https://deploy-preview-258--comforting-cocada-22086c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zuramai
Copy link
Owner

zuramai commented Sep 30, 2023

LGTM!

@zuramai zuramai merged commit 08ea552 into zuramai:main Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants