Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added comment component #265

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Conversation

Haribhajank
Copy link
Contributor

there are still two problem with this PR, if you can help me .

  1. The buttons lose their color in the dark mode , what changes has to be done to remove that.
  2. In the Vertical navbar, when the comment component is selected , the "comment" text does not get highlighted in blue color like other component.

@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for comforting-cocada-22086c ready!

Name Link
🔨 Latest commit d287b02
🔍 Latest deploy log https://app.netlify.com/sites/comforting-cocada-22086c/deploys/652400d869102700079c62b9
😎 Deploy Preview https://deploy-preview-265--comforting-cocada-22086c.netlify.app/extra-component-comment
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alfianchii alfianchii self-requested a review October 9, 2023 13:25
Copy link
Collaborator

@alfianchii alfianchii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

background-color: #ffc107;
color: #000;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to add a dark theme style, you can just simply add html[data-bs-theme="dark"].
For example:

Suggested change
// Dark theme
html[data-bs-theme="dark"] .comment {
border: 1px solid #404053;
}

Copy link
Collaborator

@alfianchii alfianchii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@alfianchii
Copy link
Collaborator

TYSM!

@alfianchii alfianchii merged commit 6f3bfce into zuramai:main Oct 9, 2023
@alfianchii alfianchii linked an issue Oct 9, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment component
2 participants