Fix off-by-one error in Dgram client retry count checking. #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transmit loop looped from 0..max_retries _exclusive_, so with the default max_retries value of 5 it would go round the loop 5 times, i.e. 1 try and 4 retries, not 5 retries. This commit adjusts the logic and allowed minimum value to match the actual behaviour. This commit also fixes a typo in the word "capped" in the doc strings.
partim
approved these changes
Jul 22, 2024
ximon18
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transmit loop looped from
0..max_retriesexclusive, so with the defaultmax_retriesvalue of 5 it would go round the loop 5 times, i.e. 1 try and 4 retries, not 5 retries.This commit adjusts the logic and allowed minimum value to match the actual behaviour.
This commit also fixes a typo in the word "capped" in the doc strings.