Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing theme causes map rendering problems #5777

Closed
flomonster opened this issue Nov 21, 2023 · 0 comments · Fixed by #5804
Closed

Changing theme causes map rendering problems #5777

flomonster opened this issue Nov 21, 2023 · 0 comments · Fixed by #5804
Assignees
@sim51
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:carto OSRD mapviz standard module severity:minor Minor severity bug

Comments

@flomonster
Copy link
Contributor

What happened?

When we change the theme some map elements don't render as expected.

Expected

2023-11-21-161256_1920x1080_scrot

What is currently render

2023-11-21-161248_1920x1080_scrot

What did you expect to happen?

The theme should be correctly applied when selected.

How can we reproduce it (as minimally and precisely as possible)?

  1. Go to "Map viewer"
  2. Select another theme
  3. Colors are weird and some objects are missing
  4. Refresh the page and everything is displayed as intended

What operating system, browser and environment are you using?

  • Browser: Firefox v119
  • OS: Nixos v23.05
  • Env: Local & Dev

OSRD version (top right corner Account button > Informations)

4e8db62
@flomonster flomonster added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules severity:minor Minor severity bug module:carto OSRD mapviz standard module mvp:required labels Nov 21, 2023
@flomonster flomonster mentioned this issue Nov 21, 2023
Merged
1 task
@Wadjetz Wadjetz self-assigned this Nov 22, 2023
@Tguisnet Tguisnet assigned sim51 and unassigned Wadjetz Nov 22, 2023
sim51 added a commit that referenced this issue Nov 22, 2023
@sim51
front: Avoid glitches on ref map when switching theme
148cbd3 
Close #5777

Maplibre bad handles the changes of layout style, which leads to somes
visualglitches on the map. Solution for now is to full reload the OSM.
@sim51 sim51 mentioned this issue Nov 22, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 23, 2023
@sim51
front: Avoid glitches on ref map when switching theme
48184c6 
Close #5777

Maplibre bad handles the changes of layout style, which leads to somes
visualglitches on the map. Solution for now is to full reload the OSM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sim51 sim51

Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:carto OSRD mapviz standard module severity:minor Minor severity bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

front: Avoid glitches on ref map when switching theme OpenRailAssociation/osrd
3 participants
@sim51 @Wadjetz @flomonster