front: Avoid glitches on ref map when switching theme #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close #5777 Maplibre bad handles the changes of layout style, which leads to somes visualglitches on the map. Solution for now is to full reload the OSM.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5804 +/- ##
============================================
+ Coverage 19.52% 19.61% +0.08%
Complexity 2332 2332
============================================
Files 907 907
Lines 107033 107658 +625
Branches 2593 2623 +30
============================================
+ Hits 20903 21114 +211
- Misses 84604 84988 +384
- Partials 1526 1556 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
approved these changes
Nov 22, 2023
nicolaswurtz
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5777
Maplibre bad handles the changes of layout style, which leads to somes visual glitches on the map.
Solution for now is to full reload the OSM.
I updated version of react-map-gl & maplibre to their latest version