Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refacto the timesStopsTable props type #8402

Closed
1 task
clarani opened this issue Aug 9, 2024 · 0 comments · Fixed by #8950
Closed
1 task

front: refacto the timesStopsTable props type #8402

clarani opened this issue Aug 9, 2024 · 0 comments · Fixed by #8950
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features

Comments

@clarani
Copy link
Contributor

clarani commented Aug 9, 2024

Description and goal

The timesStops table takes a array of SuggestedOp as main props, but it doesn't need all the fields of the SuggestedOp. This is quite painful because the Input table indeed needs whole SuggestedOp, but not the output one.

We should simplify the timesStops table props type and use a generic type so each table (input or output) can give to the timesStops component only what it needs.

Acceptance criteria

  • the code is clearer and more easily maintainable
@clarani clarani added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules labels Aug 9, 2024
@clarani clarani self-assigned this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features
Projects
None yet
1 participant