Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refacto time stops table props type #8403

Closed
wants to merge 0 commits into from

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Aug 9, 2024

closes #8402

@clarani clarani requested a review from a team as a code owner August 9, 2024 09:53
@clarani clarani force-pushed the cni-8402-refacto-timeStopsTable-props-type branch from 7fe5266 to b1af178 Compare August 9, 2024 09:53

if (row.theoreticalMargin && !marginRegExValidation.test(row.theoreticalMargin!)) {
row.isMarginValid = false;
setRows(rows);
Copy link
Contributor

@anisometropie anisometropie Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we can a way to keep the setRows inside TimesStops that would work. but that’s not good design to allow users to know implementation details of an api. we can’t let TimesStopsInput know about setRows, let alone act on it.

A solution would be to call setRows inside TimesStops no matter what, and update the store on conditions.

I made a lot of changes here, in #8334 I’d prefer to do this refacto after it’s done

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (215f207) to head (b1af178).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #8403       +/-   ##
=============================================
+ Coverage     37.29%   87.49%   +50.20%     
=============================================
  Files          1267       31     -1236     
  Lines        117671     1535   -116136     
  Branches       3182        0     -3182     
=============================================
- Hits          43881     1343    -42538     
+ Misses        71905      192    -71713     
+ Partials       1885        0     -1885     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
osrdyne ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni-8402-refacto-timeStopsTable-props-type branch from b1af178 to 887d6f1 Compare August 30, 2024 15:31
@clarani clarani marked this pull request as draft September 19, 2024 07:33
@clarani clarani closed this Sep 19, 2024
@clarani clarani force-pushed the cni-8402-refacto-timeStopsTable-props-type branch from 887d6f1 to fbf8e3e Compare September 19, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: refacto the timesStopsTable props type
3 participants