-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: refacto TimesStops props #8950
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8950 +/- ##
=========================================
Coverage 37.17% 37.17%
Complexity 2240 2240
=========================================
Files 1260 1260
Lines 115463 115497 +34
Branches 3267 3267
=========================================
+ Hits 42921 42937 +16
- Misses 70596 70614 +18
Partials 1946 1946
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job !
really good to have [rows, setRows]
and onChange
only in the input table, it’s much neater and easy to use
@anisometropie I have created this issue to refactor SuggestedOp : #8996 |
5ff18c2
to
9daac4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job :)
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
9daac4e
to
203b79f
Compare
closes #8402