Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refacto TimesStops props #8950

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Sep 20, 2024

closes #8402

@clarani clarani requested a review from a team as a code owner September 20, 2024 12:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.66265% with 140 lines in your changes missing coverage. Please review.

Project coverage is 37.17%. Comparing base (5d1dd2c) to head (203b79f).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/modules/timesStops/TimesStopsInput.tsx 0.00% 72 Missing ⚠️
...src/modules/timesStops/hooks/useOutputTableData.ts 0.00% 35 Missing ⚠️
front/src/modules/timesStops/TimesStops.tsx 0.00% 16 Missing ⚠️
...rc/modules/timesStops/hooks/useTimeStopsColumns.ts 0.00% 12 Missing ⚠️
front/src/modules/timesStops/TimesStopsOutput.tsx 0.00% 3 Missing ⚠️
front/src/modules/timesStops/helpers/utils.ts 77.77% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #8950   +/-   ##
=========================================
  Coverage     37.17%   37.17%           
  Complexity     2240     2240           
=========================================
  Files          1260     1260           
  Lines        115463   115497   +34     
  Branches       3267     3267           
=========================================
+ Hits          42921    42937   +16     
- Misses        70596    70614   +18     
  Partials       1946     1946           
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.38% <ø> (-0.01%) ⬇️
front 15.20% <15.66%> (+0.01%) ⬆️
gateway 2.22% <ø> (ø)
osrdyne 2.57% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !
really good to have [rows, setRows] and onChange only in the input table, it’s much neater and easy to use

@anisometropie anisometropie mentioned this pull request Sep 23, 2024
@clarani
Copy link
Contributor Author

clarani commented Sep 25, 2024

@anisometropie I have created this issue to refactor SuggestedOp : #8996

@clarani clarani force-pushed the cni-8402-refacto-timeStopsTable-props-type branch from 5ff18c2 to 9daac4e Compare September 25, 2024 14:50
@clarani clarani enabled auto-merge September 25, 2024 14:50
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job :)

@clarani clarani force-pushed the cni-8402-refacto-timeStopsTable-props-type branch from 9daac4e to 203b79f Compare September 25, 2024 14:59
@clarani clarani added this pull request to the merge queue Sep 25, 2024
Merged via the queue into dev with commit 627f8de Sep 25, 2024
23 checks passed
@clarani clarani deleted the cni-8402-refacto-timeStopsTable-props-type branch September 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: refacto the timesStopsTable props type
4 participants