Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The waypoint multi-select modal is dynamic #8628

Closed
6 tasks done
SharglutDev opened this issue Aug 29, 2024 · 4 comments · Fixed by #8796
Closed
6 tasks done

The waypoint multi-select modal is dynamic #8628

SharglutDev opened this issue Aug 29, 2024 · 4 comments · Fixed by #8796
Assignees
Labels
area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management

Comments

@SharglutDev
Copy link
Contributor

SharglutDev commented Aug 29, 2024

Description and goal

Now that we can display the waypoints modal, we should be able to save the changes and update the manchette accordingly.

Acceptance criteria

  • By default, the manchette should only display waypoints with these CH codes : "BV", "00", "" and vias added by map click (no ch)
  • In proportional mode, hiding a waypoint shouldn't change their position in the manchette
  • In linear mode, hiding a waypoint moves the following ones towards the previous one
  • The configuration should be saved in local storage so that when coming back to the same scenario/train, the displayed waypoints are the same
  • When deleting a (or multiple) project/study/scenario, the localStorage should be cleaned for keys containing the corresponding timetable id's
  • The space time chart should still resize according how many waypoints are displayed in the manchette
@SharglutDev SharglutDev added area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management labels Aug 29, 2024
@SharglutDev SharglutDev self-assigned this Aug 29, 2024
@Tguisnet
Copy link
Contributor

Tguisnet commented Oct 24, 2024

The main work is done,
however there is still a strange behavior for the linear case, hiding the first or last points (required),
and the warning when we only have 2 points could hide some points (optionnal)

@Tguisnet Tguisnet reopened this Oct 24, 2024
@Tguisnet
Copy link
Contributor

Tguisnet commented Oct 28, 2024

To be more precise :
If we hide the first, or the last points, we should truncate the results.
It means we should have a normal GET on the path of the manchette (with the beginning and the end of the line, with the train name, ...)
We should not see a line in the GET going outside the path of the manchette.
The behavior should be the same in linear or proportionnal mode.

@emersion
Copy link
Member

Eh, is this really the intended behavior? Even if previous OPs are hidden, it's not like the train starts at the first visible OP. Makes much more sense to make this clear by showing the continuation of the path past the first/last visible OP.

@Castavo
Copy link
Contributor

Castavo commented Nov 21, 2024

After #9513 and #9592, it is done 😁

@Castavo Castavo closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants