front: add option menu to manchette

[SharglutDev]

close #8687

As requested by @thibautsailly, the manchette menu button should remain hidden until the waypoint modal is completed (#8627 and #8628)

To test the component, uncomment it

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 105 lines in your changes missing coverage. Please review.

Project coverage is 36.89%. Comparing base (2e51022) to head (beb51be).
Report is 7 commits behind head on dev.

Files with missing lines	Patch %	Lines
.../components/SpaceTimeChart/ManchetteMenuButton.tsx	0.00%	70 Missing and 1 partial ⚠️
front/src/common/OSRDMenu.tsx	0.00%	23 Missing and 1 partial ⚠️
front/src/utils/hooks/useModalFocusTrap.ts	0.00%	6 Missing ⚠️
...WithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx	0.00%	4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #8775      +/-   ##
============================================
- Coverage     36.92%   36.89%   -0.04%     
  Complexity     2242     2242              
============================================
  Files          1255     1257       +2     
  Lines        116971   117069      +98     
  Branches       3270     3272       +2     
============================================
  Hits          43190    43190              
- Misses        71836    71932      +96     
- Partials       1945     1947       +2     

Flag	Coverage Δ
core	74.78% <ø> (ø)
editoast	72.28% <ø> (ø)
front	15.59% <0.00%> (-0.03%)	⬇️
gateway	2.22% <ø> (ø)
osrdyne	2.46% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yohh]

nice, a few suggestions first

[SharglutDev]

Also I was wondering about the reusability of the menu :
The UI from the manchette menu and the one from an op click on the manchette (see sketch) are very close. Do you think it would be better to have a "common" component for these cases and some custom props ? Like the width, items etc
But if yes, wouldn't it be better to have a component like this in osrd-ui ? (even though we didn't have a request for that)

[Yohh]

Also I was wondering about the reusability of the menu : The UI from the manchette menu and the one from an op click on the manchette (see sketch) are very close. Do you think it would be better to have a "common" component for these cases and some custom props ? Like the width, items etc But if yes, wouldn't it be better to have a component like this in osrd-ui ? (even though we didn't have a request for that)

I'm a bit confused, in this case why don't we create a component in OSRD-UI? witch could be called as a child of manchette and used for each case

[SharglutDev]

What I meant was :

The manchette menu

and the OP menu

are looking exactly the same except the items inside and the width of the menu. Maybe it should be better to have only one generic component for that to avoid code duplication.

Second question is : do we want it in osrd-ui or do we consider that it's purely an osrd component and we keep in osrd code base.

[emersion]

I've taken the liberty to rename the PR, I hope that's fine.

[kmer2016]

In the mock-up, the button for displaying the menu is located on the Header. In the implementation, however, it's outside. Are you waiting for the new version of the headline?

[SharglutDev]

In the mock-up, the button for displaying the menu is located on the Header. In the implementation, however, it's outside. Are you waiting for the new version of the headline?

Yes that's exactly why. For now the space time chart header is inside the osrd-ui components and I can't access it but the other issue will be done, I would be able to create it on osrd side and put the button at the right place.

[kmer2016]

Just small suggestions

[Yohh]

LGTM