front: fix space time chart when first or last waypoint are hidden #9513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9513 +/- ##
============================================
- Coverage 42.51% 41.81% -0.70%
Complexity 2271 2271
============================================
Files 1311 1281 -30
Lines 105413 103982 -1431
Branches 3297 3304 +7
============================================
- Hits 44812 43476 -1336
+ Misses 58655 58553 -102
- Partials 1946 1953 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
force-pushed
the
pfn/front/fix-spacetimechart-when-first-or-last-waypoint-hidden
branch
from
5894323 to
f084b1d
Compare
emersion
reviewed
Oct 29, 2024
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Oct 29, 2024
clarani
reviewed
Oct 31, 2024
clarani
reviewed
Oct 31, 2024
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Show resolved
Hide resolved
clarani
reviewed
Oct 31, 2024
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Oct 31, 2024
SharglutDev
force-pushed
the
pfn/front/fix-spacetimechart-when-first-or-last-waypoint-hidden
branch
from
f084b1d to
b984f62
Compare
SharglutDev
force-pushed
the
pfn/front/fix-spacetimechart-when-first-or-last-waypoint-hidden
branch
from
8ebc8c2 to
2ac3edb
Compare
clarani
reviewed
Nov 6, 2024
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Nov 6, 2024
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Nov 6, 2024
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Nov 6, 2024
...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
|
Sorry for the duplicate comments. It seems @clarani and I ended up reviewing in parallel without noticing. |
Filter data from projected path (path and occupancy blocks) and conflicts when the first or last waypoint is hidden. Allow the space time chart to look as if it started/ended with the first/last displayed waypoint. Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
pfn/front/fix-spacetimechart-when-first-or-last-waypoint-hidden
branch
from
127a1bf to
6954523
Compare
SharglutDev
deleted the
pfn/front/fix-spacetimechart-when-first-or-last-waypoint-hidden
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter data from projected path (path and occupancy blocks) and conflicts when the first or last waypoint is hidden. Allow the space time chart to look as if it started/ended with the first/last displayed waypoint.
part of #8628 (see last comment of the issue)
before :
after :
To test :