Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdcm: refacto and improvements for the linked path #9545

Closed
7 tasks
clarani opened this issue Oct 31, 2024 · 0 comments · Fixed by #9567 or #9571
Closed
7 tasks

stdcm: refacto and improvements for the linked path #9545

clarani opened this issue Oct 31, 2024 · 0 comments · Fixed by #9567 or #9571
Assignees
Labels
area:front Work on Standard OSRD Interface modules

Comments

@clarani
Copy link
Contributor

clarani commented Oct 31, 2024

Description and goal

We merge last week this PR to add the linked paths. However, we can improve a bit the code:

  • deactivate the path linked cards when needed (if the simulation is running or if the user has selected a simulation)
  • app crashes when I click on the datePicker to open the calendar
  • if I'm on mode debug and I try to fetch a train from a custom scenario, it does not appear. This is because my trains do not have a schedule on their last step. Actually, we should not get the final arrival time of the train from its schedule, but we should get it using the summary endpoint
  • in the simulation report sheet, should we still display the placeholders for the posterior and anterior trains ?
  • we use everywhere linked path, but I think that linked train should be more appropriate ?*

Refacto ideas

  • the component StdcmLinkedPathSearch should only take a type of linked train: ANTERIOR or POSTERIOR (we can name it LinkedTrainType). From this information, we can deduce all the other props
  • StdcmLinkedPathResults does not need the linked Op if it has the LinkedTrainType. It can simplify a lot the code

Acceptance criteria

The code related to the Linked Paths is cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
2 participants