You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We merge last week this PR to add the linked paths. However, we can improve a bit the code:
deactivate the path linked cards when needed (if the simulation is running or if the user has selected a simulation)
app crashes when I click on the datePicker to open the calendar
if I'm on mode debug and I try to fetch a train from a custom scenario, it does not appear. This is because my trains do not have a schedule on their last step. Actually, we should not get the final arrival time of the train from its schedule, but we should get it using the summary endpoint
in the simulation report sheet, should we still display the placeholders for the posterior and anterior trains ?
we use everywhere linked path, but I think that linked train should be more appropriate ?*
Refacto ideas
the component StdcmLinkedPathSearch should only take a type of linked train: ANTERIOR or POSTERIOR (we can name it LinkedTrainType). From this information, we can deduce all the other props
StdcmLinkedPathResults does not need the linked Op if it has the LinkedTrainType. It can simplify a lot the code
Acceptance criteria
The code related to the Linked Paths is cleaner
The text was updated successfully, but these errors were encountered:
Description and goal
We merge last week this PR to add the linked paths. However, we can improve a bit the code:
Refacto ideas
StdcmLinkedPathSearch
should only take a type of linked train: ANTERIOR or POSTERIOR (we can name it LinkedTrainType). From this information, we can deduce all the other propsStdcmLinkedPathResults
does not need the linked Op if it has the LinkedTrainType. It can simplify a lot the codeAcceptance criteria
The code related to the Linked Paths is cleaner
The text was updated successfully, but these errors were encountered: