Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: stdcm: add linked path search #9501

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

SarahBellaha
Copy link
Contributor

Closes #8593

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 3.13316% with 371 lines in your changes missing coverage. Please review.

Project coverage is 39.56%. Comparing base (f7f1991) to head (8a48cac).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...rc/applications/stdcm/hooks/useLinkedPathSearch.ts 0.00% 107 Missing and 1 partial ⚠️
...dcm/components/StdcmForm/StdcmLinkedPathSearch.tsx 0.00% 81 Missing and 1 partial ⚠️
...cm/components/StdcmForm/StdcmLinkedPathResults.tsx 0.00% 54 Missing and 1 partial ⚠️
...cations/stdcm/components/StdcmForm/StdcmConfig.tsx 0.00% 36 Missing ⚠️
front/src/reducers/osrdconf/stdcmConf/index.ts 18.18% 27 Missing ⚠️
...src/applications/stdcm/utils/computeOpSchedules.ts 0.00% 23 Missing and 1 partial ⚠️
front/src/applications/stdcm/hooks/useStdcmForm.ts 0.00% 13 Missing ⚠️
.../components/StdcmResults/SimulationReportSheet.tsx 0.00% 12 Missing ⚠️
front/src/utils/date.ts 40.00% 5 Missing and 1 partial ⚠️
...ns/stdcm/components/StdcmForm/StdcmDefaultCard.tsx 0.00% 2 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9501      +/-   ##
============================================
- Coverage     39.77%   39.56%   -0.21%     
  Complexity     2270     2270              
============================================
  Files          1302     1306       +4     
  Lines         99565   100046     +481     
  Branches       3282     3289       +7     
============================================
- Hits          39599    39588      -11     
- Misses        58034    58519     +485     
- Partials       1932     1939       +7     
Flag Coverage Δ
core 75.06% <ø> (ø)
editoast 73.50% <ø> (-0.08%) ⬇️
front 10.12% <3.13%> (-0.08%) ⬇️
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani self-assigned this Oct 29, 2024
@clarani clarani self-requested a review October 29, 2024 16:59
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-8593 branch 2 times, most recently from 911a854 to 336e2ad Compare October 30, 2024 08:21
@SarahBellaha SarahBellaha marked this pull request as ready for review October 30, 2024 08:23
@SarahBellaha SarahBellaha requested a review from a team as a code owner October 30, 2024 08:23
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-8593 branch from b4421e6 to b48a9cf Compare October 30, 2024 16:32
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-8593 branch from b48a9cf to 9804635 Compare October 30, 2024 16:48
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-8593 branch from 9804635 to 218dda4 Compare October 31, 2024 14:10
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-8593 branch from b73d868 to d6f00e9 Compare October 31, 2024 16:51
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall ✅

I created an enhancement issue for this feature: #9545.
We should do it as soon as we can (next week)

@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-8593 branch 3 times, most recently from ea478ed to 6359472 Compare October 31, 2024 17:36
@SarahBellaha SarahBellaha force-pushed the sba/front/stdcm-linked-path-8593 branch from 6359472 to 8a48cac Compare October 31, 2024 17:49
@SarahBellaha SarahBellaha added this pull request to the merge queue Oct 31, 2024
Merged via the queue into dev with commit aaae986 Oct 31, 2024
24 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/stdcm-linked-path-8593 branch October 31, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search for a linked path in the stdcm interface
4 participants