Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: stdcm: linked train search improvements #9571

Merged
merged 1 commit into from
Dec 16, 2024
Merged

front: stdcm: linked train search improvements #9571

merged 1 commit into from
Dec 16, 2024

Conversation

SarahBellaha
Copy link
Contributor

@SarahBellaha SarahBellaha commented Nov 5, 2024 •
edited
Loading

Closes #9618
Closes #9619
Partially closes #9545

  • App no longer crashes when using the datePicker on debug mode.
  • We now get the final arrival time using the summary endpoint.
  • The op search payload has been adapted so that it can be searched by obj_id or by uic code and ch code.

@SarahBellaha SarahBellaha requested a review from a team as a code owner November 5, 2024 14:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 95.65217% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (bf4b6ba) to head (7e9f300).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/utils/date.ts 25.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9571      +/-   ##
==========================================
+ Coverage   80.04%   80.05%   +0.01%     
==========================================
  Files        1052     1052              
  Lines      105267   105342      +75     
  Branches      759      759              
==========================================
+ Hits        84258    84334      +76     
+ Misses      20967    20966       -1     
  Partials       42       42
Flag Coverage Δ
editoast 74.23% <ø> (+<0.01%) ⬆️
front 89.25% <95.65%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Uriel-Sautron
Uriel-Sautron approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested

@SarahBellaha SarahBellaha force-pushed the sba/front/bug-fix-9545 branch 2 times, most recently from 56bea7a to 8bfb953 Compare November 15, 2024 10:00
clarani
clarani reviewed Nov 15, 2024
View reviewed changes
Uriel-Sautron
Uriel-Sautron approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, good work.

clarani
clarani reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some of my previous comments open :)

@SarahBellaha SarahBellaha force-pushed the sba/front/bug-fix-9545 branch from 9559d98 to 496e79f Compare November 25, 2024 14:54
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 25, 2024
@SarahBellaha SarahBellaha force-pushed the sba/front/bug-fix-9545 branch 2 times, most recently from 9d92ca9 to fe1fb78 Compare November 26, 2024 11:20
clarani
clarani approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Can you squash all your commits ?

@SarahBellaha SarahBellaha force-pushed the sba/front/bug-fix-9545 branch from fe1fb78 to 81c2144 Compare December 5, 2024 05:09
@SarahBellaha SarahBellaha requested a review from a team as a code owner December 5, 2024 05:09
@SarahBellaha SarahBellaha force-pushed the sba/front/bug-fix-9545 branch from 81c2144 to a37ab89 Compare December 5, 2024 07:30
Maymanaf
Maymanaf approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for e2e tests

clarani
clarani approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@SarahBellaha SarahBellaha force-pushed the sba/front/bug-fix-9545 branch 2 times, most recently from e659d2b to 63517db Compare December 10, 2024 17:03
clarani
clarani approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@SarahBellaha
front: lmr: linked train search improvements
7e9f300 
Signed-off-by: SarahBellaha <[email protected]>

front: stdcm: fix app crash when using the date picker in debug mode

front: add trigram of new selected op

front: stdcm: fix op search payload

front: lmr: be able to reset linked train search

front: lmr: fix date picker issue

front: change arrivalDate type to Date in isArrivalDateInSearchTimeWindow

front: lmr: ensure correct date handling in StdcmOpSchedule
@SarahBellaha SarahBellaha force-pushed the sba/front/bug-fix-9545 branch from 63517db to 7e9f300 Compare December 16, 2024 09:00
@SarahBellaha SarahBellaha added this pull request to the merge queue Dec 16, 2024
Merged via the queue into dev with commit e815e4f Dec 16, 2024
28 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/bug-fix-9545 branch December 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maymanaf Maymanaf Maymanaf approved these changes

@clarani clarani clarani approved these changes

@Uriel-Sautron Uriel-Sautron Uriel-Sautron approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
5 participants
@SarahBellaha @codecov-commenter @Maymanaf @clarani @Uriel-Sautron