-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: remove useless requests when deleting projects, studies, scenari #10091
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10091 +/- ##
==========================================
+ Coverage 82.56% 82.58% +0.02%
==========================================
Files 1084 1084
Lines 107256 107287 +31
Branches 728 729 +1
==========================================
+ Hits 88558 88608 +50
+ Misses 18657 18637 -20
- Partials 41 42 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5dcbc62
to
e732464
Compare
Ping :) |
e732464
to
79ef2d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, nice !
One thing though, we use a custom hook called useMultiSelection
that update the list of project/study/scenario regardless of what rtk-query does/return. It was necessary before because of our flaky use of the endpoints but now that you made these changes, we probably don't need this other item list state. This could be handled in another PR ?
Yes sure, this can be handled in another PR 👍 |
79ef2d2
to
aa2d1a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
aa2d1a6
to
503601a
Compare
closes #10008
closes #7752