Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove useless requests when deleting projects, studies, scenari #10091

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 16, 2024

closes #10008
closes #7752

@clarani clarani requested a review from a team as a code owner December 16, 2024 14:58
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (f4e0c84) to head (503601a).
Report is 26 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10091      +/-   ##
==========================================
+ Coverage   82.56%   82.58%   +0.02%     
==========================================
  Files        1084     1084              
  Lines      107256   107287      +31     
  Branches      728      729       +1     
==========================================
+ Hits        88558    88608      +50     
+ Misses      18657    18637      -20     
- Partials       41       42       +1     
Flag Coverage Δ
editoast 74.39% <ø> (-0.02%) ⬇️
front 90.51% <100.00%> (+0.03%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/10008-remove-useless-requests branch from 5dcbc62 to e732464 Compare January 3, 2025 11:33
@clarani clarani enabled auto-merge January 3, 2025 12:02
@SharglutDev
Copy link
Contributor

Ping :)

@clarani clarani force-pushed the cni/10008-remove-useless-requests branch from e732464 to 79ef2d2 Compare February 17, 2025 10:39
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, nice !

One thing though, we use a custom hook called useMultiSelection that update the list of project/study/scenario regardless of what rtk-query does/return. It was necessary before because of our flaky use of the endpoints but now that you made these changes, we probably don't need this other item list state. This could be handled in another PR ?

@clarani
Copy link
Contributor Author

clarani commented Feb 17, 2025

Yes sure, this can be handled in another PR 👍

@clarani clarani added this pull request to the merge queue Feb 17, 2025
@emersion emersion removed this pull request from the merge queue due to a manual request Feb 17, 2025
@clarani clarani force-pushed the cni/10008-remove-useless-requests branch from 79ef2d2 to aa2d1a6 Compare February 18, 2025 10:23
@clarani clarani requested a review from emersion February 18, 2025 10:23
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clarani clarani force-pushed the cni/10008-remove-useless-requests branch from aa2d1a6 to 503601a Compare February 18, 2025 16:51
@clarani clarani enabled auto-merge February 18, 2025 16:51
@clarani clarani added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@SharglutDev SharglutDev added this pull request to the merge queue Feb 18, 2025
Merged via the queue into dev with commit 0e34306 Feb 18, 2025
27 checks passed
@SharglutDev SharglutDev deleted the cni/10008-remove-useless-requests branch February 18, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
4 participants