editoast: remove InternalError usage in Delete and Create Model API

[leovalais]

• Creates a custom error type wrapping diesel::result::Error in editoast_models
• Adapt the API of deletion and creation traits (the rest will come in another PR(s))
• Propagate the API change in views (mostly)
  • new error variants are created to accommodate some (valid) typing constraints, bringing us closer to our target error management structure
  • simplified a few map_diesel_error here and there
• The traits will be moved into editoast_models::model later

Tip

Review commit by commit

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.25532% with 39 lines in your changes missing coverage. Please review.

Project coverage is 81.85%. Comparing base (c2228f0) to head (3cd4117).
Report is 33 commits behind head on dev.

Files with missing lines	Patch %	Lines
editoast/editoast_models/src/model.rs	77.08%	11 Missing ⚠️
editoast/src/models/prelude/delete.rs	57.89%	8 Missing ⚠️
editoast/src/models/prelude/create.rs	0.00%	4 Missing ⚠️
editoast/src/views/temporary_speed_limits.rs	66.66%	4 Missing ⚠️
editoast/src/views/work_schedules.rs	75.00%	4 Missing ⚠️
editoast/src/models/timetable.rs	0.00%	3 Missing ⚠️
editoast/editoast_derive/src/model/args.rs	0.00%	1 Missing ⚠️
editoast/src/models/rolling_stock_model.rs	92.30%	1 Missing ⚠️
editoast/src/models/temporary_speed_limits.rs	88.88%	1 Missing ⚠️
editoast/src/models/work_schedules.rs	88.88%	1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10196      +/-   ##
==========================================
+ Coverage   81.81%   81.85%   +0.04%     
==========================================
  Files        1073     1075       +2     
  Lines      106718   107176     +458     
  Branches      730      728       -2     
==========================================
+ Hits        87306    87724     +418     
- Misses      19373    19413      +40     
  Partials       39       39              

Flag	Coverage Δ
editoast	74.23% <79.25%> (-0.07%)	⬇️
front	89.38% <ø> (+0.03%)	⬆️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	88.14% <ø> (+1.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[woshilapin]

Nice job. Not approving yet, let's see where the comments goes first.

[woshilapin]

I think I like this Model::Error associated type, seems logical. I've put a few more comments related to the recent changes, but nothing big. Thank you.

[leovalais]

Thanks for the review! Good to know it's the right track, it's still a work in progress though (I think one commit got nuked in the process I just noticed... 👀). I'll try to finish that on monday (if I'm not trapped on permissions again, that is 😨)

[SharglutDev]

Lgtm for front (not tested)

[leovalais]

@woshilapin I've added the Error associated type of trait Model and used it in RollingStock, TemporarySpeedLimit and WorkSchedule.

I also removed some #[async_trait]s that are not useful for these definitions anymore :-)