Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: drop formatDurationAsISO8601() #10230

Merged
merged 2 commits into from
Jan 20, 2025
Merged

front: drop formatDurationAsISO8601() #10230

merged 2 commits into from
Jan 20, 2025

Conversation

emersion
Copy link
Member

@emersion emersion commented Jan 3, 2025 •
edited
Loading

See #8816

See individual commits.

Depends on #9934

@emersion emersion self-assigned this Jan 3, 2025
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 3, 2025
@emersion emersion force-pushed the emr/drop-format-duration branch from 34d98e9 to bcc203b Compare January 3, 2025 12:50
@emersion emersion force-pushed the emr/drop-format-duration branch 2 times, most recently from da75841 to 44c2751 Compare January 13, 2025 14:16
@emersion emersion force-pushed the emr/drop-format-duration branch from 44c2751 to f07391b Compare January 13, 2025 14:54
@emersion emersion marked this pull request as ready for review January 13, 2025 15:24
@emersion emersion requested a review from a team as a code owner January 13, 2025 15:24
@emersion emersion mentioned this pull request Jan 13, 2025
Merged
kmer2016
kmer2016 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

anisometropie
anisometropie approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@emersion emersion added this pull request to the merge queue Jan 20, 2025
@emersion emersion mentioned this pull request Jan 20, 2025
Open
Merged via the queue into dev with commit c155980 Jan 20, 2025
27 checks passed
@emersion emersion deleted the emr/drop-format-duration branch January 20, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisometropie anisometropie anisometropie approved these changes

@kmer2016 kmer2016 kmer2016 approved these changes

Assignees

@emersion emersion

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersion @kmer2016 @anisometropie