Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: drop ISO8601Duration2sec() #10348

Merged
merged 5 commits into from
Jan 23, 2025
Merged

front: drop ISO8601Duration2sec() #10348

merged 5 commits into from
Jan 23, 2025

Conversation

emersion
Copy link
Member

@emersion emersion commented Jan 13, 2025

See #8816

See individual commits.

Depends on #10230

@emersion emersion self-assigned this Jan 13, 2025
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 13, 2025
@emersion emersion force-pushed the emr/drop-iso-duration-to-sec branch from 36aa063 to 69a95a6 Compare January 20, 2025 15:26
@emersion emersion marked this pull request as ready for review January 20, 2025 16:59
@emersion emersion requested a review from a team as a code owner January 20, 2025 16:59
@emersion emersion requested review from Synar and clarani January 20, 2025 17:00
Copy link
Contributor

@Synar Synar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refacto!

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, super nice refacto 🧹 Thanks 🙏

@emersion emersion added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit d651580 Jan 23, 2025
27 checks passed
@emersion emersion deleted the emr/drop-iso-duration-to-sec branch January 23, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants