Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git describe version injected to the frontend #10320

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Jan 10, 2025

  • Stop using meta-env-import and use the builtin vite feature instead.
  • Set the value to development when running docker compose ...

Example when pulling the image of this PR.

Warning

I did not test with the front end embedded with the gateway.

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (9151b80) to head (9f89ea4).
Report is 18 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##              dev   #10320    +/-   ##
========================================
  Coverage   81.62%   81.62%            
========================================
  Files        1067     1070     +3     
  Lines      105624   105881   +257     
  Branches      727      727            
========================================
+ Hits        86216    86427   +211     
- Misses      19367    19415    +48     
+ Partials       41       39     -2     
Flag Coverage Δ
editoast 73.72% <ø> (+0.04%) ⬆️
front 89.32% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch from 96b3692 to 8903806 Compare January 10, 2025 14:55
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 10, 2025
@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch 9 times, most recently from 83fcd13 to 4a34ca0 Compare January 15, 2025 11:34
@flomonster flomonster marked this pull request as ready for review January 15, 2025 11:34
@flomonster flomonster requested review from a team as code owners January 15, 2025 11:34
@flomonster flomonster changed the title docker: add git describe var to gateway image with front Fix git describe version injected to the frontend Jan 15, 2025
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch from 4a34ca0 to 884d2ae Compare January 15, 2025 15:24
@flomonster flomonster removed the request for review from ElysaSrc January 15, 2025 15:25
Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM

@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch 3 times, most recently from 47be4cc to 8e8133a Compare January 16, 2025 14:18
@github-actions github-actions bot added the area:ci Work on Continous Integration Pipeline Service label Jan 16, 2025
@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch from 8e8133a to 29ecd35 Compare January 16, 2025 14:37
@github-actions github-actions bot removed the area:ci Work on Continous Integration Pipeline Service label Jan 16, 2025
@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch from 29ecd35 to a97d781 Compare January 16, 2025 14:41
@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch from 2660d1f to e6cb523 Compare January 16, 2025 15:20
@github-actions github-actions bot added the area:ci Work on Continous Integration Pipeline Service label Jan 16, 2025
@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch 3 times, most recently from 9682c1a to fe15838 Compare January 16, 2025 15:55
@github-actions github-actions bot removed area:ci Work on Continous Integration Pipeline Service area:gateway labels Jan 16, 2025
@flomonster flomonster force-pushed the fam/add-describe-front-gateway branch from fe15838 to 9f89ea4 Compare January 16, 2025 15:57
@flomonster flomonster enabled auto-merge January 16, 2025 16:06
@flomonster flomonster added this pull request to the merge queue Jan 16, 2025
Merged via the queue into dev with commit d8a1715 Jan 16, 2025
27 checks passed
@flomonster flomonster deleted the fam/add-describe-front-gateway branch January 16, 2025 16:50
@flomonster flomonster self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants