Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: repair npm start #10444

Merged
merged 1 commit into from
Jan 20, 2025
Merged

front: repair npm start #10444

merged 1 commit into from
Jan 20, 2025

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Jan 20, 2025

sh was removed in #10320 and script left untouched

@anisometropie anisometropie requested a review from a team as a code owner January 20, 2025 13:42
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 20, 2025
Signed-off-by: Valentin Chanas <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (c4c4c58) to head (1c072a5).
Report is 7 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10444      +/-   ##
==========================================
- Coverage   81.79%   81.78%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106543   106553      +10     
  Branches      727      726       -1     
==========================================
- Hits        87147    87146       -1     
- Misses      19357    19368      +11     
  Partials       39       39              
Flag Coverage Δ
editoast 74.22% <ø> (+<0.01%) ⬆️
front 89.35% <ø> (-0.02%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anisometropie anisometropie added this pull request to the merge queue Jan 20, 2025
Merged via the queue into dev with commit eb04d34 Jan 20, 2025
27 checks passed
@anisometropie anisometropie deleted the vcs/fix-npm-start branch January 20, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants