Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: LMR: fix length, mass and speed reset #10447

Merged
merged 1 commit into from
Feb 11, 2025
Merged

front: LMR: fix length, mass and speed reset #10447

merged 1 commit into from
Feb 11, 2025

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Jan 20, 2025 •
edited by Wadjetz
Loading

@Akctarus Akctarus requested a review from a team as a code owner January 20, 2025 14:05
@Akctarus Akctarus changed the title front: fix length, mass and speed reset in lmr front: LMR: fix length, mass and speed reset Jan 20, 2025
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (6774666) to head (7757f04).
Report is 19 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10447      +/-   ##
==========================================
- Coverage   81.94%   81.93%   -0.01%     
==========================================
  Files        1078     1077       -1     
  Lines      107587   107478     -109     
  Branches      733      727       -6     
==========================================
- Hits        88157    88062      -95     
+ Misses      19391    19377      -14     
  Partials       39       39
Flag Coverage Δ
editoast 74.30% <ø> (-0.10%) ⬇️
front 89.47% <100.00%> (+0.05%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/front/lmr/fix-length-mass-speed-reset branch 5 times, most recently from 854df7b to 1522505 Compare January 22, 2025 14:28
@SharglutDev SharglutDev mentioned this pull request Jan 23, 2025
Closed
@achrafmohye
Copy link
Contributor

achrafmohye commented Jan 23, 2025 •
edited
Loading

@Akctarus When i select Traction engine using the combobox above i have these messages on each filled input is it the intended behaviour ? and have to close them manually which is more of a ui-core improvement
image

@Wadjetz Wadjetz mentioned this pull request Jan 23, 2025
Closed
@Akctarus
Copy link
Contributor Author

@Akctarus When i select Traction engine using the combobox above i have these messages on each filled input is it the intended behaviour ? and have to close them manually which is more of a ui-core improvement image

yes it is, the user must be informed visually as soon as the app changes a piece of data he had previously changed. To close them, yes maybe we should improve that, but in any case the messages close by themselves, if we change traction engine

@Akctarus Akctarus requested review from SharglutDev and removed request for emersion January 24, 2025 08:38
@Akctarus Akctarus force-pushed the tmn/front/lmr/fix-length-mass-speed-reset branch 2 times, most recently from 78cd147 to 8e73583 Compare January 24, 2025 12:45
@Akctarus Akctarus requested a review from a team as a code owner January 24, 2025 16:10
@Maymanaf Maymanaf removed the request for review from a team January 27, 2025 09:43
SharglutDev
SharglutDev reviewed Jan 27, 2025
View reviewed changes
@Akctarus Akctarus force-pushed the tmn/front/lmr/fix-length-mass-speed-reset branch 2 times, most recently from 30f3388 to 75eecee Compare January 27, 2025 15:47
@Maymanaf Maymanaf self-requested a review January 27, 2025 16:38
@Akctarus Akctarus force-pushed the tmn/front/lmr/fix-length-mass-speed-reset branch 3 times, most recently from 0901f41 to 9d86d3c Compare February 10, 2025 15:53
@achrafmohye
Copy link
Contributor

Can you rebase your branch please, for easier testing :)

@Akctarus Akctarus force-pushed the tmn/front/lmr/fix-length-mass-speed-reset branch from e7351dc to 8842e61 Compare February 11, 2025 09:32
@Akctarus
Copy link
Contributor Author

Can you rebase your branch please, for easier testing :)

done !

SharglutDev
SharglutDev approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@Akctarus Akctarus removed the request for review from Maymanaf February 11, 2025 13:40
achrafmohye
achrafmohye approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested Thanks :)

@Akctarus Akctarus force-pushed the tmn/front/lmr/fix-length-mass-speed-reset branch from 8842e61 to 7757f04 Compare February 11, 2025 15:54
@Akctarus Akctarus enabled auto-merge February 11, 2025 15:54
@Akctarus Akctarus added this pull request to the merge queue Feb 11, 2025
Merged via the queue into dev with commit 9342d4c Feb 11, 2025
27 checks passed
@Akctarus Akctarus deleted the tmn/front/lmr/fix-length-mass-speed-reset branch February 11, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achrafmohye achrafmohye achrafmohye approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
4 participants
@Akctarus @codecov-commenter @achrafmohye @SharglutDev