Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix stdcm empty ch list in new query #10451

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

SharglutDev
Copy link
Contributor

fix #10410

@SharglutDev SharglutDev requested a review from a team as a code owner January 20, 2025 16:35
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (8affe7b) to head (8221856).
Report is 18 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10451      +/-   ##
==========================================
- Coverage   81.78%   81.78%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106574   106593      +19     
  Branches      731      731              
==========================================
+ Hits        87161    87176      +15     
- Misses      19374    19378       +4     
  Partials       39       39              
Flag Coverage Δ
editoast 74.21% <ø> (-0.02%) ⬇️
front 89.34% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, left a comment but does not block approval

@SharglutDev SharglutDev force-pushed the pfn/front/fix-stdcm-ch-list branch from 601f66f to 8221856 Compare January 21, 2025 14:54
@clarani
Copy link
Contributor

clarani commented Jan 21, 2025

Related to #10401

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SharglutDev SharglutDev enabled auto-merge January 21, 2025 18:02
@SharglutDev SharglutDev added this pull request to the merge queue Jan 21, 2025
Merged via the queue into dev with commit 48c27ca Jan 21, 2025
27 checks passed
@SharglutDev SharglutDev deleted the pfn/front/fix-stdcm-ch-list branch January 21, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: when creating a request from an accepted simulation, waypoints have no CH Code
5 participants