Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: account for previous margins when checking for new ones #10506

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jan 23, 2025

Fix #10505

@eckter eckter requested a review from Erashin January 23, 2025 13:40
@eckter eckter requested a review from a team as a code owner January 23, 2025 13:40
@github-actions github-actions bot added the area:core Work on Core Service label Jan 23, 2025
@eckter eckter force-pushed the ech/fix-margin-ranges branch from f537125 to 09a6cd2 Compare January 23, 2025 13:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (c2228f0) to head (09a6cd2).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10506      +/-   ##
==========================================
- Coverage   81.81%   81.80%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106718   106718              
  Branches      730      730              
==========================================
- Hits        87306    87302       -4     
- Misses      19373    19377       +4     
  Partials       39       39              
Flag Coverage Δ
editoast 74.28% <ø> (-0.02%) ⬇️
front 89.34% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eckter eckter added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit a90a394 Jan 23, 2025
27 checks passed
@eckter eckter deleted the ech/fix-margin-ranges branch January 23, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: stdcm: weird behavior on engineering allowance ranges
3 participants