-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: editoast: add flag to ignore infra speed limits #10681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10681 +/- ##
==========================================
- Coverage 81.92% 81.92% -0.01%
==========================================
Files 1079 1079
Lines 107547 107550 +3
Branches 734 734
==========================================
- Hits 88113 88109 -4
- Misses 19394 19401 +7
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e834a62
to
37324e3
Compare
e70e492
to
b29487e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/standalone_sim/SimulationRequest.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/api_v2/standalone_sim/SimulationRequest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok for editoast
but something weird showed up. Since it's not part of your PR, feel free to discard it, but if it could be fixed with it, that'd be great.
editoast/editoast_schemas/src/train_schedule/train_schedule_options.rs
Outdated
Show resolved
Hide resolved
ce5d262
to
eab77e0
Compare
editoast/editoast_schemas/src/train_schedule/train_schedule_options.rs
Outdated
Show resolved
Hide resolved
editoast/editoast_schemas/src/train_schedule/train_schedule_options.rs
Outdated
Show resolved
Hide resolved
eab77e0
to
f4136e8
Compare
97d078c
to
2809ce7
Compare
Signed-off-by: Alex Rolland <[email protected]> Signed-off-by: Jean SIMARD <[email protected]>
2809ce7
to
47e5449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a flag to ignore infra speed limits in a standalone simulation.
This will be useful in BASIC import to fix late trains for the moment.
Closes #10587