Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: editoast: add flag to ignore infra speed limits #10681

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

axrolld
Copy link
Contributor

@axrolld axrolld commented Feb 5, 2025

Add a flag to ignore infra speed limits in a standalone simulation.

This will be useful in BASIC import to fix late trains for the moment.

Closes #10587

@github-actions github-actions bot added area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:core Work on Core Service area:editoast Work on Editoast Service labels Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (9210d41) to head (47e5449).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10681      +/-   ##
==========================================
- Coverage   81.92%   81.92%   -0.01%     
==========================================
  Files        1079     1079              
  Lines      107547   107550       +3     
  Branches      734      734              
==========================================
- Hits        88113    88109       -4     
- Misses      19394    19401       +7     
  Partials       40       40              
Flag Coverage Δ
editoast 74.37% <100.00%> (-0.02%) ⬇️
front 89.41% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 5, 2025
@woshilapin woshilapin force-pushed the ard/flag-speed-limits branch from e834a62 to 37324e3 Compare February 5, 2025 11:03
@axrolld axrolld force-pushed the ard/flag-speed-limits branch 5 times, most recently from e70e492 to b29487e Compare February 6, 2025 10:56
@axrolld axrolld marked this pull request as ready for review February 6, 2025 15:40
@axrolld axrolld requested review from a team as code owners February 6, 2025 15:40
@axrolld axrolld requested a review from eckter February 6, 2025 15:40
@axrolld axrolld changed the title core: editoast: add flag to ignore infra speed limits core: editoast: front: add flag to ignore infra speed limits Feb 6, 2025
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for editoast but something weird showed up. Since it's not part of your PR, feel free to discard it, but if it could be fixed with it, that'd be great.

@axrolld axrolld force-pushed the ard/flag-speed-limits branch 3 times, most recently from ce5d262 to eab77e0 Compare February 7, 2025 10:52
@axrolld axrolld force-pushed the ard/flag-speed-limits branch from eab77e0 to f4136e8 Compare February 7, 2025 13:28
@woshilapin woshilapin force-pushed the ard/flag-speed-limits branch 2 times, most recently from 97d078c to 2809ce7 Compare February 7, 2025 14:11
Signed-off-by: Alex Rolland <[email protected]>
Signed-off-by: Jean SIMARD <[email protected]>
@woshilapin woshilapin force-pushed the ard/flag-speed-limits branch from 2809ce7 to 47e5449 Compare February 7, 2025 14:13
@axrolld axrolld removed the request for review from SarahBellaha February 7, 2025 14:33
@axrolld axrolld changed the title core: editoast: front: add flag to ignore infra speed limits core: editoast: add flag to ignore infra speed limits Feb 7, 2025
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axrolld axrolld added this pull request to the merge queue Feb 7, 2025
Merged via the queue into dev with commit 5b4dc6f Feb 7, 2025
27 checks passed
@axrolld axrolld deleted the ard/flag-speed-limits branch February 7, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:railjson Work on Proposed Unified Rail Assets Data Exchange Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flag to enable ignoring speed limits
5 participants