Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, python: rename use infra speed limits tag #10829

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

Morgane-SJK
Copy link
Contributor

Following this PR : #10681

We want to use the same name everywhere (sometimes we used UseInfraSpeedLimits and sometimes UseSpeedLimits)

@Morgane-SJK Morgane-SJK requested review from a team as code owners February 17, 2025 13:44
@Morgane-SJK Morgane-SJK requested a review from Erashin February 17, 2025 13:44
@github-actions github-actions bot added area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:core Work on Core Service labels Feb 17, 2025
@Morgane-SJK Morgane-SJK removed the request for review from Erashin February 17, 2025 13:44
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (d1389d4) to head (18e3298).
Report is 12 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10829      +/-   ##
==========================================
+ Coverage   81.93%   82.56%   +0.63%     
==========================================
  Files        1084     1084              
  Lines      107216   107260      +44     
  Branches      737      728       -9     
==========================================
+ Hits        87846    88558     +712     
+ Misses      19329    18661     -668     
  Partials       41       41              
Flag Coverage Δ
editoast 74.39% <ø> (+<0.01%) ⬆️
front 90.47% <ø> (+0.97%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Morgane-SJK Morgane-SJK force-pushed the mso/fix-speed-limit-flag-naming branch from c602a28 to 649bfec Compare February 17, 2025 13:48
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated. It removes an incoherence indeed.

Copy link
Contributor

@axrolld axrolld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@axrolld axrolld added this pull request to the merge queue Feb 17, 2025
@axrolld axrolld removed this pull request from the merge queue due to a manual request Feb 17, 2025
@axrolld axrolld force-pushed the mso/fix-speed-limit-flag-naming branch from 16e74b6 to 18e3298 Compare February 17, 2025 15:57
@Morgane-SJK Morgane-SJK added this pull request to the merge queue Feb 17, 2025
Merged via the queue into dev with commit 0dc91a9 Feb 17, 2025
27 checks passed
@Morgane-SJK Morgane-SJK deleted the mso/fix-speed-limit-flag-naming branch February 17, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service area:railjson Work on Proposed Unified Rail Assets Data Exchange Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants