Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No auth for sprites #10828

Merged
merged 1 commit into from
Feb 17, 2025
Merged

No auth for sprites #10828

merged 1 commit into from
Feb 17, 2025

Conversation

Tristramg
Copy link
Contributor

All the sprites and signaling systems are committed in the public repository.
There is no need to complicate the code with an auth check

@Tristramg Tristramg requested a review from a team as a code owner February 17, 2025 11:03
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (d1389d4) to head (8cb6e7d).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10828      +/-   ##
==========================================
- Coverage   81.93%   81.93%   -0.01%     
==========================================
  Files        1084     1084              
  Lines      107216   107199      -17     
  Branches      737      737              
==========================================
- Hits        87846    87829      -17     
  Misses      19329    19329              
  Partials       41       41              
Flag Coverage Δ
editoast 74.37% <100.00%> (-0.02%) ⬇️
front 89.49% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tristramg Tristramg requested a review from flomonster February 17, 2025 11:33
@Tristramg Tristramg enabled auto-merge February 17, 2025 13:30
@Tristramg Tristramg added this pull request to the merge queue Feb 17, 2025
Merged via the queue into dev with commit f1b10fb Feb 17, 2025
27 checks passed
@Tristramg Tristramg deleted the no_auth_for_sprites branch February 17, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants