editoast, front: host fonts for the map in editoast #10788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:front
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10788 +/- ##
=======================================
Coverage 81.93% 81.93%
=======================================
Files 1084 1085 +1
Lines 107199 107232 +33
Branches 737 737
=======================================
+ Hits 87832 87863 +31
- Misses 19326 19328 +2
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tristramg
force-pushed
the
fonts_in_editoast
branch
from
5514494 to
2bd29b5
Compare
Tristramg
force-pushed
the
fonts_in_editoast
branch
2 times, most recently
from
c5a9319 to
35865d0
Compare
Tristramg
force-pushed
the
all_sprites
branch
from
fcb377b to
7283410
Compare
Tristramg
force-pushed
the
fonts_in_editoast
branch
6 times, most recently
from
0af99d4 to
ab89c1a
Compare
Tristramg
force-pushed
the
all_sprites
branch
3 times, most recently
from
c0f4b22 to
8caf39b
Compare
Tristramg
force-pushed
the
fonts_in_editoast
branch
from
ab89c1a to
674f86c
Compare
woshilapin
changed the title
woshilapin
approved these changes
Feb 14, 2025
Tristramg
force-pushed
the
fonts_in_editoast
branch
from
58d8372 to
8176887
Compare
flomonster
reviewed
Feb 17, 2025
Tristramg
force-pushed
the
fonts_in_editoast
branch
2 times, most recently
from
03e78cd to
f9f8bdd
Compare
emersion
reviewed
Feb 17, 2025
emersion
approved these changes
Feb 17, 2025
The glyphs are generated during the build step Closes #10627 Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg
force-pushed
the
fonts_in_editoast
branch
from
f9f8bdd to
7cadb58
Compare
|
I re-arranged the commits |
Akctarus
reviewed
Feb 18, 2025
| @@ -61,6 +61,9 @@ | |||
| "electrical_profiles": { | |||
| "NotFound": "Profil électrique '{{electrical_profile_set_id}}' non trouvé" | |||
| }, | |||
| "fonts": { | |||
| "FileNotFound": "Fichier pour la police de charactère demandée non trouvé" | |||
There was a problem hiding this comment.
there is a typo : caractère instead of charactère
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glyphs are generated during the build step
Closes #10627
How to test: open the map, filter network requests by
robotoand make sure that everything is 200 and is now on localhost.(Should probably be merged after #10680 and #10628)