Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create paced trains model and add post and delete endpoints #10842

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Feb 18, 2025

Close #10888

@github-actions github-actions bot added the area:editoast Work on Editoast Service label Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.21053% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (0152d77) to head (e1d59ac).
Report is 81 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/paced_train.rs 90.00% 4 Missing ⚠️
front/src/common/api/generatedEditoastApi.ts 73.33% 4 Missing ⚠️
editoast/src/views/timetable.rs 91.42% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10842      +/-   ##
==========================================
- Coverage   82.57%   81.63%   -0.95%     
==========================================
  Files        1084     1098      +14     
  Lines      107404   110595    +3191     
  Branches      730      742      +12     
==========================================
+ Hits        88687    90279    +1592     
- Misses      18675    20274    +1599     
  Partials       42       42              
Flag Coverage Δ
editoast 72.32% <96.00%> (-2.07%) ⬇️
front 90.22% <73.33%> (-0.26%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 2.98% <ø> (-0.31%) ⬇️
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch 4 times, most recently from 49bacde to 94fa0d3 Compare February 18, 2025 23:16
@github-actions github-actions bot added the area:integration-tests Work on Integration test, by nature related to different services label Feb 18, 2025
@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch from 94fa0d3 to cdd4b0b Compare February 18, 2025 23:49
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 18, 2025
@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch 7 times, most recently from 30bb380 to cbfc4b6 Compare February 20, 2025 18:30
@younesschrifi younesschrifi marked this pull request as ready for review February 20, 2025 18:58
@younesschrifi younesschrifi requested review from a team as code owners February 20, 2025 18:58
@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch 2 times, most recently from a6dfdce to 6fcf24c Compare February 21, 2025 09:29
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory review.

I wonder if mod paced_train shouldn't be included in mod timetable since there's a bunch of visibility changes of existing definitions (that usually is a signal that something's wrong). (I know that we have DELETE /paced_trains and not DELETE /timetable/paced_trains, but URL path hierarchy and rust module trees are two different things that do not necessarily require correlation imo.)

Wdyt?

@younesschrifi
Copy link
Contributor Author

younesschrifi commented Feb 21, 2025

Cursory review.

I wonder if mod paced_train shouldn't be included in mod timetable since there's a bunch of visibility changes of existing definitions (that usually is a signal that something's wrong). (I know that we have DELETE /paced_trains and not DELETE /timetable/paced_trains, but URL path hierarchy and rust module trees are two different things that do not necessarily require correlation imo.)

Wdyt?

don't totally agree. We'd like to use paced trains in cases where the timetable is decorelated, as will perhaps be the case with train schedules. Maybe there won't be such a case, and if it's not the case I think it's a good idea to put paced train in timetable, but we'd have to put train schedule there too, wouldn't we?

@leovalais
Copy link
Contributor

We'd like to use paced trains in cases where the timetable is decorelated

I'm not saying we should change the URL scheme, DELETE /paced_train is fine for the reasons you mentioned. However nothing prevents us from putting mod paced_train in mod timetable as it can be convenient to share some definitions without compromising visibility (and locality).

What I'm trying to say is that the module tree doesn't necessarily have to match our URLs paths. We're currently a bit forced to do that because of the routes! macro, but if we had all the paths defined in a single file, we'd have no constraint on module trees whatsoever.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first review, a few things are missing like indexes in the DB migration or the update of osrd_schemas.

@github-actions github-actions bot added the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Feb 24, 2025
@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch 4 times, most recently from a82dd5a to 2f81ec5 Compare February 24, 2025 13:13
@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch 2 times, most recently from 7507d4c to d589a6f Compare February 24, 2025 13:37
@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch from 6b1b815 to cd7dcb3 Compare February 26, 2025 09:35
@github-actions github-actions bot removed the area:integration-tests Work on Integration test, by nature related to different services label Feb 26, 2025
@younesschrifi younesschrifi removed request for a team and bloussou February 26, 2025 09:37
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (not tested)

@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch from cd7dcb3 to fad67d2 Compare February 27, 2025 07:48
@flomonster flomonster changed the title create paced trains model and add post and delete endpoints Create paced trains model and add post and delete endpoints Feb 27, 2025
@github-actions github-actions bot removed the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Feb 27, 2025
@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch 3 times, most recently from 883fc16 to abd0bea Compare February 27, 2025 10:38
@younesschrifi younesschrifi force-pushed the yci/create-paced-trains-model branch from abd0bea to e1d59ac Compare February 27, 2025 11:03
@younesschrifi younesschrifi added this pull request to the merge queue Feb 27, 2025
Merged via the queue into dev with commit e058c5a Feb 27, 2025
27 checks passed
@younesschrifi younesschrifi deleted the yci/create-paced-trains-model branch February 27, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: create paced train model and add Post / Delete endpoints
8 participants