front: fix isEqualDate() #10846
Merged
front: fix isEqualDate() #10846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toLocaleString() returns an arbitrary human-readable string. For instance, in France it returns "18/02/2025 13:32:08" and in Korea it returns "2025. 2. 18. 오후 1:32:08". The string cannot be used for anything else than display. Trying to extract the date from it will not work: substring(0, 10) will give "2025. 2. 1" in Korea (dropping the "8"). As a result, any day with the same first digit will be interpreted as equal. Fix this by comparing the year, month, and day of the month instead. Signed-off-by: Simon Ser <[email protected]>
Yohh
approved these changes
Feb 24, 2025
Yohh
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toLocaleString() returns an arbitrary human-readable string. For instance, in France it returns "18/02/2025 13:32:08" and in Korea it returns "2025. 2. 18. 오후 1:32:08".
The string cannot be used for anything else than display. Trying to extract the date from it will not work: substring(0, 10) will give "2025. 2. 1" in Korea (dropping the "8"). As a result, any day with the same first digit will be interpreted as equal.
Fix this by comparing the year, month, and day of the month instead.