add timetable train type filter #10976
Merged
+529
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharglutDev
force-pushed
the
pfn/front/add-timetable-train-type-filter
branch
from
dfa4d8f to
2994a38
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10976 +/- ##
==========================================
- Coverage 80.69% 80.63% -0.07%
==========================================
Files 1098 1099 +1
Lines 111892 112216 +324
Branches 745 745
==========================================
+ Hits 90296 90489 +193
- Misses 21553 21684 +131
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SharglutDev
changed the title
SharglutDev
force-pushed
the
pfn/front/add-timetable-train-type-filter
branch
3 times, most recently
from
d362ec8 to
af71c36
Compare
theocrsb
reviewed
Mar 4, 2025
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/operationalStudies/_scenario.scss
Outdated
Show resolved
Hide resolved
|
I think the white stripes are missing Mockup : |
Hmm I have them on my computer : Note Your screen made me see that the color for the filter panel toggle button was wrong so I changed it |
|
Fixed the white border top |
2 tasks
Maymanaf
reviewed
Mar 5, 2025
front/tests/pages/operational-studies/scenario-timetable-section.ts
Outdated
Show resolved
Hide resolved
front/tests/pages/operational-studies/scenario-timetable-section.ts
Outdated
Show resolved
Hide resolved
front/tests/pages/operational-studies/scenario-timetable-section.ts
Outdated
Show resolved
Hide resolved
front/tests/pages/operational-studies/scenario-timetable-section.ts
Outdated
Show resolved
Hide resolved
Maymanaf
reviewed
Mar 5, 2025
Signed-off-by: SharglutDev <[email protected]>
Signed-off-by: SharglutDev <[email protected]>
Bootstrap default config add a "margin-bottom: 0.5rem" to the label element that was added with osrd-ui's one. Signed-off-by: SharglutDev <[email protected]>
Signed-off-by: SharglutDev <[email protected]>
Signed-off-by: SharglutDev <[email protected]>
Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
pfn/front/add-timetable-train-type-filter
branch
from
e4fcf86 to
2ba3c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits
close #10610
Mockup : https://www.sketch.com/s/2fb064cd-c483-46ac-bd30-72705fd63e75/a/YZkJDEv